Commit 4ff6389e authored by Scott Vokes's avatar Scott Vokes
Browse files

Replace INIT macros with init functions in src/lib/kinetic_types_internal.c. 

This is in preparation for changing the HMAC auth initialization, to
also allow pinOp-based authentication.
parent 5b9d209f

src/lib/kinetic_allocator.c

+3 −3
Original line number Diff line number Diff line
@@ -208,7 +208,7 @@ KineticPDU* KineticAllocator_NewPDU(KineticConnection* connection) 
        return NULL;

    }

    assert(newPDU->proto == NULL);

    KINETIC_PDU_INIT(newPDU, connection);

    KineticPDU_Init(newPDU, connection);

    LOGF3("Allocated new PDU (0x%0llX) on connection", newPDU, connection);

    return newPDU;

}
@@ -283,9 +283,9 @@ KineticOperation* KineticAllocator_NewOperation(KineticConnection* const connect 
        LOGF0("Failed allocating new operation on connection (0x%0llX)!", connection);

        return NULL;

    }

    KINETIC_OPERATION_INIT(newOperation, connection);

    KineticOperation_Init(newOperation, connection);

    newOperation->request = KineticAllocator_NewPDU(connection);

    KINETIC_PDU_INIT_WITH_COMMAND(newOperation->request, connection);

    KineticPDU_InitWithCommand(newOperation->request, connection);

    LOGF3("Allocated new operation (0x%0llX) on connection (0x%0llX)", newOperation, connection);

    return newOperation;

}

src/lib/kinetic_message.c

+0 −6
Original line number Diff line number Diff line
@@ -21,12 +21,6 @@ 
#include "kinetic_message.h"

#include "kinetic_logger.h"



void KineticMessage_Init(KineticMessage* const message)

{

    assert(message != NULL);

    KINETIC_MESSAGE_INIT(message);

}



// e.g. CONFIG_FIELD_BYTE_BUFFER(key, message->keyValue, entry)

#define CONFIG_FIELD_BYTE_BUFFER(_name, _field, _entry) { \

    if ((_entry)->_name.array.data != NULL \

src/lib/kinetic_message.h

+0 −1
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ 
#include "kinetic_types_internal.h"

#include "kinetic_hmac.h"



void KineticMessage_Init(KineticMessage* const message);

void KineticMessage_ConfigureKeyValue(KineticMessage* const message,

                                      const KineticEntry* entry);

void KineticMessage_ConfigureKeyRange(KineticMessage* const message,

src/lib/kinetic_pdu.c

+0 −7
Original line number Diff line number Diff line
@@ -26,13 +26,6 @@ 
#include "kinetic_logger.h"

#include "kinetic_proto.h"





void KineticPDU_Init(KineticPDU* const pdu,

                     KineticConnection* const connection)

{

    KINETIC_PDU_INIT(pdu, connection);

}



KineticStatus KineticPDU_ReceiveMain(KineticPDU* const response)

{

    assert(response != NULL);

src/lib/kinetic_pdu.h

+0 −1
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ 


#include "kinetic_types_internal.h"



void KineticPDU_Init(KineticPDU* const pdu, KineticConnection* const connection);

KineticStatus KineticPDU_Send(KineticPDU* request);

KineticStatus KineticPDU_ReceiveMain(KineticPDU* response);

KineticStatus KineticPDU_ReceiveValue(int socket_desc, ByteBuffer* value, size_t value_length);