Commit 9accb0c6 authored by Zhu Yong's avatar Zhu Yong
Browse files

change constant from ALL_CAP to CamelCase, follow the rule of golint

parent f92ed820
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -124,17 +124,20 @@ func (c *GetLogCallback) Success(resp *kproto.Command, value []byte) {
	c.Logs = getLogFromProto(resp)
}

// BatchEndCallback is the Callback for Command_END_BATCH
type BatchEndCallback struct {
	GenericCallback
	BatchStatus BatchStatus
}

// Success extracts all sequence IDs for commands (PUT/DELETE) performed in batch.
func (c *BatchEndCallback) Success(resp *kproto.Command, value []byte) {
	c.GenericCallback.Success(resp, value)
	c.BatchStatus.DoneSequence = resp.GetBody().GetBatch().GetSequence()
	c.BatchStatus.FailedSequence = resp.GetBody().GetBatch().GetFailedSequence()
}

// Failure extracts the first failed operation sequence in batch.
func (c *BatchEndCallback) Failure(resp *kproto.Command, status Status) {
	c.GenericCallback.Failure(resp, status)
	c.BatchStatus.DoneSequence = resp.GetBody().GetBatch().GetSequence()
+39 −39
Original line number Diff line number Diff line
@@ -58,32 +58,32 @@ func TestBlockNoOp(t *testing.T) {

func TestBlockGet(t *testing.T) {
	_, status, err := blockConn.Get([]byte("object000"))
	// Object might not exist, expect to see OK status, or REMOTE_NOT_FOUND
	if err != nil || (status.Code != OK && status.Code != REMOTE_NOT_FOUND) {
	// Object might not exist, expect to see OK status, or RemoteNotFound
	if err != nil || (status.Code != OK && status.Code != RemoteNotFound) {
		t.Fatal("Blocking Get Failure", err, status.String())
	}
}

func TestBlockGetNext(t *testing.T) {
	_, status, err := blockConn.GetNext([]byte("object000"))
	// Object might not exist, expect to see OK status, or REMOTE_NOT_FOUND
	if err != nil || (status.Code != OK && status.Code != REMOTE_NOT_FOUND) {
	// Object might not exist, expect to see OK status, or RemoteNotFound
	if err != nil || (status.Code != OK && status.Code != RemoteNotFound) {
		t.Fatal("Blocking GetNext Failure", err, status.String())
	}
}

func TestBlockGetPrevious(t *testing.T) {
	_, status, err := blockConn.GetPrevious([]byte("object000"))
	// Object might not exist, expect to see OK status, or REMOTE_NOT_FOUND
	if err != nil || (status.Code != OK && status.Code != REMOTE_NOT_FOUND) {
	// Object might not exist, expect to see OK status, or RemoteNotFound
	if err != nil || (status.Code != OK && status.Code != RemoteNotFound) {
		t.Fatal("Blocking GetPrevious Failure", err, status.String())
	}
}

func TestBlockGetVersion(t *testing.T) {
	version, status, err := blockConn.GetVersion([]byte("object000"))
	// Object might not exist, expect to see OK status, or REMOTE_NOT_FOUND
	if err != nil || (status.Code != OK && status.Code != REMOTE_NOT_FOUND) {
	// Object might not exist, expect to see OK status, or RemoteNotFound
	if err != nil || (status.Code != OK && status.Code != RemoteNotFound) {
		t.Fatal("Blocking GetVersion Failure", err, status.String())
	}
	t.Logf("Object version = %x", version)
@@ -100,8 +100,8 @@ func TestBlockPut(t *testing.T) {
	entry := Record{
		Key:   []byte("object000"),
		Value: []byte("ABCDEFG"),
		Sync:  SYNC_WRITETHROUGH,
		Algo:  ALGO_SHA1,
		Sync:  SyncWriteThrough,
		Algo:  AlgorithmSHA1,
		Tag:   []byte(""),
		Force: true,
	}
@@ -117,14 +117,14 @@ func TestBlockPut_keyOverflow(t *testing.T) {
	entry := Record{
		Key:   bytes.Repeat([]byte("K"), int(blockConn.nbc.service.device.Limits.MaxKeySize+1)),
		Value: []byte("ABCDEFG"),
		Sync:  SYNC_WRITETHROUGH,
		Algo:  ALGO_SHA1,
		Sync:  SyncWriteThrough,
		Algo:  AlgorithmSHA1,
		Tag:   []byte(""),
		Force: true,
	}
	status, err := blockConn.Put(&entry)
	// Request with key buffer overflow, expect to see failure code REMOTE_INVALID_REQUEST
	if err != nil || status.Code != REMOTE_INVALID_REQUEST {
	// Request with key buffer overflow, expect to see failure code RemoteInvalidRequest
	if err != nil || status.Code != RemoteInvalidRequest {
		t.Fatal("Blocking Put Failure", err, status.String())
	}
}
@@ -135,14 +135,14 @@ func TestBlockPut_valueOverflow(t *testing.T) {
	entry := Record{
		Key:   []byte("key"),
		Value: bytes.Repeat([]byte("V"), int(blockConn.nbc.service.device.Limits.MaxValueSize+1)),
		Sync:  SYNC_WRITETHROUGH,
		Algo:  ALGO_SHA1,
		Sync:  SyncWriteThrough,
		Algo:  AlgorithmSHA1,
		Tag:   []byte(""),
		Force: true,
	}
	status, err := blockConn.Put(&entry)
	// Request with value buffer overflow, expect to see failure code REMOTE_INVALID_REQUEST
	if err != nil || status.Code != REMOTE_INVALID_REQUEST {
	// Request with value buffer overflow, expect to see failure code RemoteInvalidRequest
	if err != nil || status.Code != RemoteInvalidRequest {
		t.Fatal("Blocking Put Failure", err, status.String())
	}
}
@@ -156,14 +156,14 @@ func TestBlockPut_tagOverflow(t *testing.T) {
	entry := Record{
		Key:   []byte("key"),
		Value: []byte("value"),
		Sync:  SYNC_WRITETHROUGH,
		Algo:  ALGO_SHA1,
		Sync:  SyncWriteThrough,
		Algo:  AlgorithmSHA1,
		Tag:   bytes.Repeat([]byte("T"), int(blockConn.nbc.service.device.Limits.MaxTagSize+1)),
		Force: true,
	}
	status, err := blockConn.Put(&entry)
	// Request with tag buffer overflow, expect to see failure code REMOTE_INVALID_REQUEST
	if err != nil || status.Code != REMOTE_INVALID_REQUEST {
	// Request with tag buffer overflow, expect to see failure code RemoteInvalidRequest
	if err != nil || status.Code != RemoteInvalidRequest {
		t.Fatal("Blocking Put Failure", err, status.String())
	}
}
@@ -171,8 +171,8 @@ func TestBlockPut_tagOverflow(t *testing.T) {
func TestBlockDelete(t *testing.T) {
	entry := Record{
		Key:   []byte("object000"),
		Sync:  SYNC_WRITETHROUGH,
		Algo:  ALGO_SHA1,
		Sync:  SyncWriteThrough,
		Algo:  AlgorithmSHA1,
		Force: true,
	}
	status, err := blockConn.Delete(&entry)
@@ -200,7 +200,7 @@ func TestBlockGetKeyRange(t *testing.T) {

func TestBlockGetLogCapacity(t *testing.T) {
	logs := []LogType{
		LOG_CAPACITIES,
		LogTypeCapacities,
	}
	klogs, status, err := blockConn.GetLog(logs)
	if err != nil || status.Code != OK {
@@ -215,7 +215,7 @@ func TestBlockGetLogCapacity(t *testing.T) {

func TestBlockGetLogLimit(t *testing.T) {
	logs := []LogType{
		LOG_LIMITS,
		LogTypeLimits,
	}
	klogs, status, err := blockConn.GetLog(logs)
	if err != nil || status.Code != OK {
@@ -230,13 +230,13 @@ func TestBlockGetLogLimit(t *testing.T) {

func TestBlockGetLogAll(t *testing.T) {
	logs := []LogType{
		LOG_UTILIZATIONS,
		LOG_TEMPERATURES,
		LOG_CAPACITIES,
		LOG_CONFIGURATION,
		LOG_STATISTICS,
		LOG_MESSAGES,
		LOG_LIMITS,
		LogTypeUtilizations,
		LogTypeTemperatures,
		LogTypeCapacities,
		LogTypeConfiguration,
		LogTypeStatistics,
		LogTypeMessages,
		LogTypeLimits,
	}
	klogs, status, err := blockConn.GetLog(logs)
	if err != nil || status.Code != OK {
@@ -261,7 +261,7 @@ func TestBlockMediaScan(t *testing.T) {
		StartKeyInclusive: true,
		EndKeyInclusive:   true,
	}
	status, err := blockConn.MediaScan(&op, PRIORITY_NORMAL)
	status, err := blockConn.MediaScan(&op, PriorityNormal)
	if err != nil || status.Code != OK {
		t.Fatal("Blocking MediaScan Failure: ", err, status.String())
	}
@@ -274,18 +274,18 @@ func TestBlockMediaOptimize(t *testing.T) {
		StartKeyInclusive: true,
		EndKeyInclusive:   true,
	}
	status, err := blockConn.MediaOptimize(&op, PRIORITY_NORMAL)
	status, err := blockConn.MediaOptimize(&op, PriorityNormal)
	if err != nil || status.Code != OK {
		t.Fatal("Blocking MediaOptimize Failure: ", err, status.String())
	}
}

func TestSetPowerLevel(t *testing.T) {
	status, err := blockConn.SetPowerLevel(POWER_HIBERNATE)
	status, err := blockConn.SetPowerLevel(PowerLevelHibernate)
	if err != nil || status.Code != OK {
		t.Fatal("Blocking SetPowerLevel Failure: ", err, status.String())
	}
	status, err = blockConn.SetPowerLevel(POWER_OPERATIONAL)
	status, err = blockConn.SetPowerLevel(PowerLevelOperational)
	if err != nil || status.Code != OK {
		t.Fatal("Blocking SetPowerLevel Failure: ", err, status.String())
	}
@@ -299,8 +299,8 @@ func TestBlockSetClusterVersion(t *testing.T) {

	blockConn.SetClientClusterVersion(2)
	_, status, err = blockConn.Get([]byte("object000"))
	if err != nil || status.Code != REMOTE_CLUSTER_VERSION_MISMATCH {
		t.Fatal("Blocking Get expected REMOTE_CLUSTER_VERSION_MISMATCH. ", err, status.String())
	if err != nil || status.Code != RemoteClusterVersionMismatch {
		t.Fatal("Blocking Get expected RemoteClusterVersionMismatch. ", err, status.String())
	}
	t.Log(status.String())
}
+35 −35
Original line number Diff line number Diff line
@@ -26,25 +26,25 @@ type LogType int32

const (
	_                    LogType = iota
	LOG_UTILIZATIONS  LogType = iota
	LOG_TEMPERATURES  LogType = iota
	LOG_CAPACITIES    LogType = iota
	LOG_CONFIGURATION LogType = iota
	LOG_STATISTICS    LogType = iota
	LOG_MESSAGES      LogType = iota
	LOG_LIMITS        LogType = iota
	LOG_DEVICE        LogType = iota
	LogTypeUtilizations  LogType = iota
	LogTypeTemperatures  LogType = iota
	LogTypeCapacities    LogType = iota
	LogTypeConfiguration LogType = iota
	LogTypeStatistics    LogType = iota
	LogTypeMessages      LogType = iota
	LogTypeLimits        LogType = iota
	LogTypeDevice        LogType = iota
)

var strLogType = map[LogType]string{
	LOG_UTILIZATIONS:  "LOG_UTILIZATIONS",
	LOG_TEMPERATURES:  "LOG_TEMPERATURES",
	LOG_CAPACITIES:    "LOG_CAPACITIES",
	LOG_CONFIGURATION: "LOG_CONFIGURATION",
	LOG_STATISTICS:    "LOG_STATISTICS",
	LOG_MESSAGES:      "LOG_MESSAGES",
	LOG_LIMITS:        "LOG_LIMITS",
	LOG_DEVICE:        "LOG_DEVICE",
	LogTypeUtilizations:  "LOG_UTILIZATIONS",
	LogTypeTemperatures:  "LOG_TEMPERATURES",
	LogTypeCapacities:    "LOG_CAPACITIES",
	LogTypeConfiguration: "LOG_CONFIGURATION",
	LogTypeStatistics:    "LOG_STATISTICS",
	LogTypeMessages:      "LOG_MESSAGES",
	LogTypeLimits:        "LOG_LIMITS",
	LogTypeDevice:        "LOG_DEVICE",
}

func (l LogType) String() string {
@@ -58,21 +58,21 @@ func (l LogType) String() string {
func convertLogTypeToProto(l LogType) kproto.Command_GetLog_Type {
	ret := kproto.Command_GetLog_INVALID_TYPE
	switch l {
	case LOG_UTILIZATIONS:
	case LogTypeUtilizations:
		ret = kproto.Command_GetLog_UTILIZATIONS
	case LOG_TEMPERATURES:
	case LogTypeTemperatures:
		ret = kproto.Command_GetLog_TEMPERATURES
	case LOG_CAPACITIES:
	case LogTypeCapacities:
		ret = kproto.Command_GetLog_CAPACITIES
	case LOG_CONFIGURATION:
	case LogTypeConfiguration:
		ret = kproto.Command_GetLog_CONFIGURATION
	case LOG_STATISTICS:
	case LogTypeStatistics:
		ret = kproto.Command_GetLog_STATISTICS
	case LOG_MESSAGES:
	case LogTypeMessages:
		ret = kproto.Command_GetLog_MESSAGES
	case LOG_LIMITS:
	case LogTypeLimits:
		ret = kproto.Command_GetLog_LIMITS
	case LOG_DEVICE:
	case LogTypeDevice:
		ret = kproto.Command_GetLog_DEVICE
	}
	return ret
@@ -82,21 +82,21 @@ func convertLogTypeFromProto(l kproto.Command_GetLog_Type) LogType {
	var ret LogType
	switch l {
	case kproto.Command_GetLog_UTILIZATIONS:
		ret = LOG_UTILIZATIONS
		ret = LogTypeUtilizations
	case kproto.Command_GetLog_TEMPERATURES:
		ret = LOG_TEMPERATURES
		ret = LogTypeTemperatures
	case kproto.Command_GetLog_CAPACITIES:
		ret = LOG_CAPACITIES
		ret = LogTypeCapacities
	case kproto.Command_GetLog_CONFIGURATION:
		ret = LOG_CONFIGURATION
		ret = LogTypeConfiguration
	case kproto.Command_GetLog_STATISTICS:
		ret = LOG_STATISTICS
		ret = LogTypeStatistics
	case kproto.Command_GetLog_MESSAGES:
		ret = LOG_MESSAGES
		ret = LogTypeMessages
	case kproto.Command_GetLog_LIMITS:
		ret = LOG_LIMITS
		ret = LogTypeLimits
	case kproto.Command_GetLog_DEVICE:
		ret = LOG_DEVICE
		ret = LogTypeDevice
	}
	return ret
}
@@ -144,7 +144,7 @@ type ConfigurationLog struct {
	ProtocolSourceHash      string                   // Device supported protocol source code repository hash value
	Interface               []ConfigurationInterface // Device interfaces as list
	Port                    int32                    // Service port
	TlsPort                 int32                    // TLS service port
	TLSPort                 int32                    // TLS service port
	CurrentPowerLevel       PowerLevel               // Device current power level, valid value only POWER_HIBERNATE or POWER_OPERATIONAL
}

@@ -272,7 +272,7 @@ func getConfigurationLogFromProto(getlog *kproto.Command_GetLog) (log *Configura
			ProtocolSourceHash:      conf.GetProtocolSourceHash(),
			Interface:               getConfigurationInterfaceFromProto(conf),
			Port:                    conf.GetPort(),
			TlsPort:                 conf.GetTlsPort(),
			TLSPort:                 conf.GetTlsPort(),
			CurrentPowerLevel:       convertPowerLevelFromProto(conf.GetCurrentPowerLevel()),
		}
	}
+1 −1
Original line number Diff line number Diff line
@@ -21,8 +21,8 @@ import (
	"bytes"
	"testing"

	proto "github.com/golang/protobuf/proto"
	kproto "github.com/Kinetic/kinetic-go/proto"
	proto "github.com/golang/protobuf/proto"
)

func TestHmacEmptyMessage(t *testing.T) {
+282 −282

File changed.

Preview size limit exceeded, changes collapsed.

Loading