Commit 7990f9a0 authored by Marshall Pierce's avatar Marshall Pierce
Browse files

Merge pull request #26 from Seagate/features/improved-kineticstat-error-reporting 

Add detailed error messages to kineticstat example
parents 56d40650 00520df6

CMakeLists.txt

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ else(USE_LOCAL_KINETIC_CLIENT) 
        kinetic_cpp_client

        PREFIX "vendor"

        GIT_REPOSITORY "https://github.com/Seagate/kinetic-cpp-client.git"

        GIT_TAG "0.0.3"

        GIT_TAG "ed4e0d3a670145a6ebe7b1b211268b788338b8c3"

        BUILD_IN_SOURCE 1

        INSTALL_COMMAND ""

    )

src/kineticstat.cc

+5 −13
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ 


#include "kinetic/kinetic.h"

#include "gflags/gflags.h"

#include "util.h"



using kinetic::DriveLog;

using kinetic::Capacity;
@@ -51,28 +52,19 @@ int example_main( 
        char** argv) {

    if (FLAGS_type == "all") {

        unique_ptr<DriveLog> drive_log;

        if(!blocking_connection->GetLog(drive_log).ok()) {

            printf("Unable to get log\n");

            return 1;

        }

        PerformKineticOpOrExit(blocking_connection->GetLog(drive_log));



        dump_all_information(*drive_log);

    } else if (FLAGS_type == "log") {

        unique_ptr<DriveLog> drive_log;

        if(!blocking_connection->GetLog(drive_log).ok()) {

            printf("Unable to get log\n");

            return 1;

        }

        PerformKineticOpOrExit(blocking_connection->GetLog(drive_log));



        printf("%s\n", drive_log->messages.c_str());

    } else {

        int report_number = 0;

        while (true) {

            unique_ptr<DriveLog> drive_log;

            if(!blocking_connection->GetLog(drive_log).ok()) {

                printf("Unable to get log\n");

                return 1;

            }

            PerformKineticOpOrExit(blocking_connection->GetLog(drive_log));



            bool print_headers = report_number % 5 == 0;

src/util.h

0 → 100644
+11 −0
Original line number Diff line number Diff line 
#ifndef KINETIC_CPP_EXAMPLES_H_

#define KINETIC_CPP_EXAMPLES_H_



void PerformKineticOpOrExit(kinetic::KineticStatus status) {

  if (!status.ok()) {

    fprintf(stderr, "KineticError: %d %s\n", status.statusCode(), status.message().c_str());

    exit(1);

  }

}



#endif  // KINETIC_CPP_EXAMPLES_H_