Commit fd6b3e9d authored by Kevin.Liu's avatar Kevin.Liu
Browse files

Merge pull request #12 from Seagate/develop 

Fixed issues #10, #10 submitted by Andy
parents fef1fc5c 113116e2

include/kinetic_client.h

+1 −1
Original line number Diff line number Diff line
@@ -28,7 +28,7 @@ 
 * 

 * @return Returns a pointer to static version info

 */

KineticVersionInfo KineticClient_Version(void);

const KineticVersionInfo * KineticClient_Version(void);



/**

 * Initializes the Kinetic API and configures logging.

src/lib/kinetic_admin_client.c

+1 −1
Original line number Diff line number Diff line
@@ -222,7 +222,7 @@ KineticStatus KineticAdminClient_GetDeviceSpecificLog(KineticSession * const ses 
    return KineticController_ExecuteOperation(operation, closure);

}



void KineticClient_FreeLogInfo(KineticSession * const session,

void KineticAdminClient_FreeLogInfo(KineticSession * const session,

                                  KineticLogInfo* info)

{

    KINETIC_ASSERT(session != NULL);

src/lib/kinetic_client.c

+2 −2
Original line number Diff line number Diff line
@@ -39,9 +39,9 @@ static const KineticVersionInfo VersionInfo = { 
    .repoCommitHash = KINETIC_C_REPO_HASH,

};



KineticVersionInfo KineticClient_Version(void)

const KineticVersionInfo * KineticClient_Version(void)

{

    return VersionInfo;

    return &VersionInfo;

}



KineticClient * KineticClient_Init(KineticClientConfig *config)

test/unit/test_kinetic_client.c

+4 −4
Original line number Diff line number Diff line
@@ -59,10 +59,10 @@ void tearDown(void) 


void test_KineticClient_Version_should_return_pointer_to_static_version_info(void)

{

    KineticVersionInfo info = KineticClient_Version();

    TEST_ASSERT_EQUAL_STRING(KINETIC_C_VERSION, info.version);

    TEST_ASSERT_EQUAL_STRING(KINETIC_C_PROTOCOL_VERSION, info.protocolVersion);

    TEST_ASSERT_EQUAL_STRING(KINETIC_C_REPO_HASH, info.repoCommitHash);

    KineticVersionInfo *info = KineticClient_Version();

    TEST_ASSERT_EQUAL_STRING(KINETIC_C_VERSION, info->version);

    TEST_ASSERT_EQUAL_STRING(KINETIC_C_PROTOCOL_VERSION, info->protocolVersion);

    TEST_ASSERT_EQUAL_STRING(KINETIC_C_REPO_HASH, info->repoCommitHash);

}



void test_KineticClient_Init_should_initialize_the_message_bus_and_return_a_new_client(void)