Commit b487ef07 authored by Greg Williams's avatar Greg Williams
Browse files

Enabled all warnings for test and release builds, and fixed most of the... 

Enabled all warnings for test and release builds, and fixed most of the warnings. Fixed syntax error in kinetic-c utility
parent 3b5f4470

Rakefile

+1 −0
Original line number Diff line number Diff line
@@ -272,6 +272,7 @@ task :test_all do 
  java_sim_start

  Rake::Task['test:path'].reenable

  Rake::Task['test:path'].invoke('test/system')

  Rake::Task['release'].invoke

  java_sim_shutdown



  report_banner "Finished executing all test suites"

project.yml

+13 −2
Original line number Diff line number Diff line
@@ -87,8 +87,8 @@ 
      - -D"$": COLLECTION_DEFINES_TEST_AND_VENDOR

      - -D"$": DEFINES_TEST_PREPROCESS

      - -DGNU_COMPILER

      - -w

      - -Wformat

      - -std=c99

      - -Wall

      - ${1}

  :test_linker:

    :executable: gcc
@@ -105,6 +105,17 @@ 
      - "-l crypto"

      - ${1}

      - -o ${2}

  :release_compiler:

    :executable: gcc

    :arguments:

      - -I"$": 'COLLECTION_PATHS_SOURCE_INCLUDE_VENDOR'

      - -I"$": 'COLLECTION_PATHS_RELEASE_TOOLCHAIN_INCLUDE'

      - -D"$": 'COLLECTION_DEFINES_RELEASE_AND_VENDOR'

      - -DGNU_COMPILER

      - -std=c99

      - -Wall

      - "-c \"${1}\""

      - "-o \"${2}\""

  :release_linker:

    :executable: gcc

    :name: release_linker

src/lib/kinetic_logger.c

+0 −1
Original line number Diff line number Diff line
@@ -99,7 +99,6 @@ void KineticLogger_LogHeader(const KineticPDUHeader* header) 
#define LOG_PROTO_INIT() \

    unsigned int _i; \

    char _indent[32] = "  "; \

    char _buf[1024]; \

    const char* _str_true = "true"; \

    const char* _str_false = "false";

src/lib/kinetic_pdu.c

+0 −1
Original line number Diff line number Diff line
@@ -35,7 +35,6 @@ void KineticPDU_Init( 
    uint8_t* const value,

    int32_t valueLength)

{

    size_t packedLength = 0;

    assert(pdu != NULL);

    assert(exchange != NULL);

src/lib/kinetic_socket.c

+0 −3
Original line number Diff line number Diff line
@@ -276,7 +276,6 @@ void KineticSocket_Close(int socketDescriptor) 
bool KineticSocket_Read(int socketDescriptor, void* buffer, size_t length)

{

    size_t count;

    uint8_t* data = (uint8_t*)buffer;



    for (count = 0; count < length; )

    {
@@ -369,7 +368,6 @@ bool KineticSocket_Write(int socketDescriptor, const void* buffer, size_t length 
{

    int status;

    size_t count;

    uint8_t* data = (uint8_t*)buffer;

    char msg[128];



    for (count = 0; count < length; )
@@ -404,7 +402,6 @@ bool KineticSocket_Write(int socketDescriptor, const void* buffer, size_t length 


bool KineticSocket_WriteProtobuf(int socketDescriptor, const KineticProto* proto)

{

    bool success = false;

    size_t len = KineticProto_get_packed_size(proto);

    size_t packedLen;

    char msg[64];