Commit 9d2d016e authored by Greg Williams's avatar Greg Williams
Browse files

Added details to README and release notes to note new dependency on json-c. 

Removed increase of log line size, since unnecessary.
Added memset of session struct to async test to eliminate segfault.
parent 35f1095f

README.md

+9 −0
Original line number Diff line number Diff line
@@ -20,6 +20,15 @@ Prerequisites 
            * `> sudo apt-get install openssl`

        * OSX (using [Homebrew](http://brew.sh/))

            * `> brew install openssl`

* [json-c](https://github.com/json-c/json-c) for JSON-formatted ACL definition files

    * NOTE: Supplied as a Get submodule

    * Installation (via autotools)

        * `> cd vendor/json-c`

        * `> sh autogen.sh`

        * `> ./configure`

        * `> make`

        * `> sudo make install`

    * Installation is further detailed in the json-c README

            

A release of OpenSSL that provides TLS 1.1 or newer is required.

RELEASE.md

+1 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ v0.11.0 (kinetic-protocol 3.0.5) 
* Added options for the number of writer, reader, and max threadpool threads, with defaults.

* Added KineticClient_FreeDeviceInfo to free the `KineticDeviceInfo` structure allocated by `KineticClient_GetLog`.

* Added several new examples under src/examples/.

* Added json-c library dependency which will be used for JSON-formatted ACL files for upcoming Admin API and multi-cast drive discovery tool.



v0.10.1 (kinetic-protocol 3.0.5)

--------------------------------

src/lib/kinetic_logger.c

+1 −1
Original line number Diff line number Diff line
@@ -28,7 +28,7 @@ 
#include <pthread.h>

#include <time.h>



#define KINETIC_LOGGER_BUFFER_STR_MAX_LEN 256

#define KINETIC_LOGGER_BUFFER_STR_MAX_LEN 512

#define KINETIC_LOGGER_BUFFER_SIZE (0x1 << 12)

#define KINETIC_LOGGER_FLUSH_INTERVAL_SEC 180

#define KINETIC_LOGGER_SLEEP_TIME_SEC 10

src/lib/kinetic_operation.c

+14 −7
Original line number Diff line number Diff line
@@ -157,8 +157,22 @@ static KineticStatus KineticOperation_SendRequestInner(KineticOperation* const o 
    size_t len = KineticProto_Message__pack(&request->message.message, &msg[offset]);

    assert(len == header.protobufLength);

    offset += header.protobufLength;



    assert(operation);

    assert(operation->request);

    assert(operation->connection);

    assert(request);

    LOGF2("[PDU TX] pdu: %p, op: %p, session: %p, bus: %p, fd: %6d, seq: %5lld, protoLen: %4u, valueLen: %u",

        (void*)operation->request, (void*)operation,

        (void*)operation->connection->pSession, (void*)operation->connection->messageBus,

        operation->connection->socket, request->message.header.sequence,

        header.protobufLength, header.valueLength);

    KineticLogger_LogHeader(3, &header);

    KineticLogger_LogProtobuf(3, proto);



    free(request->message.message.commandBytes.data);

    request->message.message.commandBytes.data = NULL;



    // Send the value/payload, if specified

    if (header.valueLength > 0) {

        memcpy(&msg[offset], operation->entry->value.array.data, operation->entry->value.bytesUsed);
@@ -188,13 +202,6 @@ static KineticStatus KineticOperation_SendRequestInner(KineticOperation* const o 
        status = KINETIC_STATUS_SOCKET_ERROR;

    }

    else {

        LOGF2("[PDU TX] pdu: %p, op: %p, session: %p, bus: %p, fd: %6d, seq: %5lld, protoLen: %4u, valueLen: %u",

            (void*)operation->request, (void*)operation,

            (void*)operation->connection->pSession, (void*)operation->connection->messageBus,

            operation->connection->socket, request->message.header.sequence,

            header.protobufLength, header.valueLength);

        KineticLogger_LogHeader(3, &header);

        KineticLogger_LogProtobuf(3, proto);

        status = KINETIC_STATUS_SUCCESS;

    }

test/system/test_system_overlapped_io.c

+1 −0
Original line number Diff line number Diff line
@@ -99,6 +99,7 @@ void test_kinetic_client_should_be_able_to_store_an_arbitrarily_large_binary_obj 
        // Establish all of the connection first, so their session can all get initialized first

        for (int i = 0; i < NUM_COPIES; i++) {

            // Establish connection

            memset(&kt_arg[i].session, 0, sizeof(KineticSession));

            kt_arg[i].session.config = sessionConfig;

            TEST_ASSERT_EQUAL_KineticStatus(

                KINETIC_STATUS_SUCCESS,