Commit 4abd54b9 authored by Greg Williams's avatar Greg Williams
Browse files

Updated destination buffer sizes for GetLog messages tests so buffer doee not... 

Updated destination buffer sizes for GetLog messages tests so buffer doee not overflow when we have a significant amount of log data
parent ebf57e2d

src/lib/kinetic_logger.c

+4 −2
Original line number Diff line number Diff line
@@ -914,10 +914,12 @@ void KineticLogger_LogProtobuf(int log_level, const KineticProto_Message* msg) 
                        // * protobuf_c_boolean has_messages;

                        // * ProtobufCBinaryData messages;

                        if (cmd->body->getLog->has_messages) {

                            BYTES_TO_CSTRING(tmpBuf,

                            uint8_t* buf = malloc(cmd->body->getLog->messages.len * 4);

                            BYTES_TO_CSTRING(buf,

                                cmd->body->getLog->messages,

                                0, cmd->body->getLog->messages.len);

                            KineticLogger_LogPrintf(log_level, "%smessages: '%s'", _indent, tmpBuf);

                            KineticLogger_LogPrintf(log_level, "%smessages: '%s'", _indent, buf);

                            free(buf);

                        }

                            

                        // * KineticProto_Command_GetLog_Limits* limits;

test/support/system_test_fixture.h

+0 −1
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ 


#ifndef SYSTEM_TEST_HOST

#define SYSTEM_TEST_HOST "localhost"

// #define SYSTEM_TEST_HOST "10.138.123.65"

#endif



typedef struct _SystemTestFixture {

test/system/test_system_get_log.c

+4 −8
Original line number Diff line number Diff line
@@ -70,13 +70,9 @@ void test_GetLog_should_retrieve_utilizations_from_device(void) 
    TEST_ASSERT_EQUAL_KineticStatus(KINETIC_STATUS_SUCCESS, Status);

    TEST_ASSERT_NOT_NULL(Info);

    TEST_ASSERT_NOT_NULL(Info->utilizations);

    TEST_ASSERT_EQUAL(4, Info->numUtilizations);

    TEST_ASSERT_NOT_NULL(Info->utilizations[0].name);

    TEST_ASSERT_NOT_NULL(Info->utilizations[1].name);

    TEST_ASSERT_NOT_NULL(Info->utilizations[2].name);

    TEST_ASSERT_NOT_NULL(Info->utilizations[3].name);



    for (size_t i = 0; i < 4; i++) {

    TEST_ASSERT_TRUE(Info->numUtilizations >= 4);

    for (size_t i = 0; i < Info->numUtilizations; i++) {

        TEST_ASSERT_NOT_NULL(Info->utilizations[i].name);

        KineticDeviceInfo_Utilization* utilization = &Info->utilizations[i];

        LOGF0("info->utilizations[%zu]: %s = %.3f", i, utilization->name, utilization->value);

    }
@@ -161,7 +157,7 @@ void test_GetLog_should_retrieve_statistics_from_device(void) 
    }

}



uint8_t* Buffer[1024 * 1024 * 4];

uint8_t* Buffer[1024 * 1024 * 10];



void test_GetLog_should_retrieve_messages_from_device(void)

{ LOG_LOCATION;