Commit 39442bf1 authored by Scott Vokes's avatar Scott Vokes
Browse files

Eliminate KineticClientConfig.writerThreads, since sender threads are gone.

parent 1a38fba7

include/kinetic_types.h

+0 −2
Original line number Diff line number Diff line
@@ -446,7 +446,6 @@ struct _KineticP2P_Operation { 
 * if the corresponding field in the struct is 0.

 */

#define KINETIC_CLIENT_DEFAULT_LOG_LEVEL 0

#define KINETIC_CLIENT_DEFAULT_WRITER_THREADS 4

#define KINETIC_CLIENT_DEFAULT_READER_THREADS 4

#define KINETIC_CLIENT_DEFAULT_MAX_THREADPOOL_THREADS 8
@@ -459,7 +458,6 @@ struct _KineticP2P_Operation { 
typedef struct {

    const char *logFile;            ///< Path to log file. Specify 'stdout' to log to STDOUT or NULL to disable logging.

    int logLevel;                   ///< Logging level (-1:none, 0:error, 1:info, 2:verbose, 3:full)

    uint8_t writerThreads;          ///< Number of threads used for handling outgoing requests

    uint8_t readerThreads;          ///< Number of threads used for handling incoming responses and status messages

    uint8_t maxThreadpoolThreads;   ///< Max number of threads to use for the threadpool that handles response callbacks.

} KineticClientConfig;

src/lib/kinetic_bus.c

+0 −1
Original line number Diff line number Diff line
@@ -258,7 +258,6 @@ bool KineticBus_Init(KineticClient * client, KineticClientConfig * config) 
        .unpack_cb = unpack_cb,

        .unexpected_msg_cb = KineticController_HandleUnexpectedResponse,

        .bus_udata = NULL,

        .sender_count = config->writerThreads,

        .listener_count = config->readerThreads,

        .threadpool_cfg = {

            .max_threads = config->maxThreadpoolThreads,

src/lib/kinetic_client.c

+0 −3
Original line number Diff line number Diff line
@@ -38,9 +38,6 @@ KineticClient * KineticClient_Init(KineticClientConfig *config) 
    if (client == NULL) { return NULL; }



    /* Use defaults if set to 0. */

    if (config->writerThreads == 0) {

        config->writerThreads = KINETIC_CLIENT_DEFAULT_WRITER_THREADS;

    }

    if (config->readerThreads == 0) {

        config->readerThreads = KINETIC_CLIENT_DEFAULT_READER_THREADS;

    }

test/system/test_system_stress_single_session_threaded.c

+0 −1
Original line number Diff line number Diff line
@@ -345,7 +345,6 @@ void test_kinetic_client_throughput_test_kinetic_client_throughput_(void) 
    KineticClientConfig config = {

        .logFile = "stdout",

        .logLevel = 0,

        .writerThreads = 1,

        .readerThreads = 1,

        .maxThreadpoolThreads = 1,

    };