Commit 01c88edb authored by Greg Williams's avatar Greg Williams
Browse files

Got PDU transmission complete. Still need to tackle PDU receive and wiring in... 

Got PDU transmission complete. Still need to tackle PDU receive and wiring in of population/validation of HMAC
parent d5f0272a

src/lib/kinetic_connection.c

+23 −2
Original line number Diff line number Diff line
@@ -50,9 +50,30 @@ bool KineticConnection_Connect( 


bool KineticConnection_SendPDU(KineticPDU* const request)

{

    // .... NEED TO SEND THE MESSAGE STILL!!!!!!!

    int fd = request->exchange->connection->FileDescriptor;



    return (request->protobuf->status.code == KINETIC_PROTO_STATUS_STATUS_CODE_SUCCESS);

    // Send the PDU header

    if (!KineticSocket_Write(fd, &request->header, sizeof(KineticPDUHeader)))

    {

        return false;

    }



    // Send the protobuf message

    if (!KineticSocket_WriteProtobuf(fd, request->protobuf))

    {

        return false;

    }



    // Send the value/payload, if specified

    if ((request->valueLength > 0) && (request->value != NULL))

    {

        if (!KineticSocket_Write(fd, request->value, request->valueLength))

        {

            return false;

        }

    }



    return true;

}



bool KineticConnection_ReceivePDU(KineticPDU* const response)

test/unit/test_kinetic_connection.c

+73 −12
Original line number Diff line number Diff line
@@ -113,37 +113,95 @@ void test_KineticConnection_SendPDU_should_send_the_PDU_and_report_success(void) 


    DoConnect();



    KineticMessage_Init(&MessageOut);

    MessageOut.status.code = KINETIC_PROTO_STATUS_STATUS_CODE_SUCCESS; // Fake success for now

    KineticPDU_Init(&PDUOut, &Exchange, &MessageOut, value, sizeof(value));



    Connection.Connected = true;

    Connection.Blocking = true;

    Connection.Port = 1234;

    Connection.FileDescriptor = 456;

    strcpy(Connection.Host, "valid-host.com");

    Expected = Connection;



    KineticSocket_Write_ExpectAndReturn(456, &PDUOut.header, sizeof(KineticPDUHeader), true);

    KineticSocket_WriteProtobuf_ExpectAndReturn(456, PDUOut.protobuf, true);

    KineticSocket_Write_ExpectAndReturn(456, PDUOut.value, PDUOut.valueLength, true);



    status = KineticConnection_SendPDU(&PDUOut);



    TEST_ASSERT_TRUE(status);

    TEST_ASSERT_EQUAL_KINETIC_STATUS(KINETIC_PROTO_STATUS_STATUS_CODE_SUCCESS, MessageOut.status.code);



    TEST_IGNORE_MESSAGE("Need to actually send the message still!");

}





void test_KineticConnection_SendPDU_should_send_the_specified_message_and_report_failure(void)

void test_KineticConnection_SendPDU_should_send_the_specified_message_and_report_failure_to_send_header(void)

{

    bool status;

    uint8_t buffer[20], value[10];



    DoConnect();



    KineticPDU_Init(&PDUOut, &Exchange, &MessageOut, value, sizeof(value));



    Connection.Connected = true;

    Connection.Blocking = true;

    Connection.Port = 1234;

    Connection.FileDescriptor = 456;

    strcpy(Connection.Host, "valid-host.com");

    Expected = Connection;



    KineticSocket_Write_ExpectAndReturn(456, &PDUOut.header, sizeof(KineticPDUHeader), false);



    status = KineticConnection_SendPDU(&PDUOut);



    TEST_ASSERT_FALSE(status);

}



void test_KineticConnection_SendPDU_should_send_the_specified_message_and_report_failure_to_send_protobuf(void)

{

    bool status;

    uint8_t buffer[20], value[10];



    DoConnect();



    KineticMessage_Init(&MessageOut);

    MessageOut.status.code = KINETIC_PROTO_STATUS_STATUS_CODE_NO_SUCH_HMAC_ALGORITHM; // Fake failure for now

    KineticPDU_Init(&PDUOut, &Exchange, &MessageOut, value, sizeof(value));



    Connection.Connected = true;

    Connection.Blocking = true;

    Connection.Port = 1234;

    Connection.FileDescriptor = 456;

    strcpy(Connection.Host, "valid-host.com");

    Expected = Connection;



    KineticSocket_Write_ExpectAndReturn(456, &PDUOut.header, sizeof(KineticPDUHeader), true);

    KineticSocket_WriteProtobuf_ExpectAndReturn(456, PDUOut.protobuf, false);



    status = KineticConnection_SendPDU(&PDUOut);



    TEST_ASSERT_FALSE(status);

}



    TEST_ASSERT_EQUAL_KINETIC_STATUS(KINETIC_PROTO_STATUS_STATUS_CODE_NO_SUCH_HMAC_ALGORITHM, MessageOut.status.code);

void test_KineticConnection_SendPDU_should_send_the_specified_message_and_report_failure(void)

{

    bool status;

    uint8_t buffer[20], value[10];



    DoConnect();



    KineticPDU_Init(&PDUOut, &Exchange, &MessageOut, value, sizeof(value));



    TEST_IGNORE_MESSAGE("Need to actually send the message still!");

    Connection.Connected = true;

    Connection.Blocking = true;

    Connection.Port = 1234;

    Connection.FileDescriptor = 456;

    strcpy(Connection.Host, "valid-host.com");

    Expected = Connection;



    KineticSocket_Write_ExpectAndReturn(456, &PDUOut.header, sizeof(KineticPDUHeader), true);

    KineticSocket_WriteProtobuf_ExpectAndReturn(456, PDUOut.protobuf, true);

    KineticSocket_Write_ExpectAndReturn(456, PDUOut.value, PDUOut.valueLength, false);



    status = KineticConnection_SendPDU(&PDUOut);



    TEST_ASSERT_FALSE(status);

}



void test_KineticConnection_ReceivePDU_should_receive_a_message_for_the_exchange_and_report_success(void)
@@ -153,7 +211,6 @@ void test_KineticConnection_ReceivePDU_should_receive_a_message_for_the_exchange 


    DoConnect();



    KineticMessage_Init(&MessageIn);

    MessageIn.status.code = KINETIC_PROTO_STATUS_STATUS_CODE_SUCCESS; // Fake success for now

    KineticPDU_Init(&PDUIn, &Exchange, &MessageIn, value, sizeof(value));
@@ -173,7 +230,6 @@ void test_KineticConnection_ReceivePDU_should_receive_a_message_for_the_exchange 


    DoConnect();



    KineticMessage_Init(&MessageIn);

    MessageIn.status.code = KINETIC_PROTO_STATUS_STATUS_CODE_PERM_DATA_ERROR; // Fake success for now

    KineticPDU_Init(&PDUIn, &Exchange, &MessageIn, value, sizeof(value));
@@ -185,3 +241,8 @@ void test_KineticConnection_ReceivePDU_should_receive_a_message_for_the_exchange 


    TEST_IGNORE_MESSAGE("Need to actually receive the message still!");

}



void test_SOMEONE_needs_to_configure_or_validate_HMAC_on_messages(void)

{

    TEST_IGNORE_MESSAGE("INCOMPLETE!");

}